Improve query capabilities #932
Conversation
v2/coord/coordinator.go
Outdated
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| seeds, err := c.GetClosestNodes(ctx, msg.Target(), 20) |
There was a problem hiding this comment.
we should make 20 configurable
There was a problem hiding this comment.
Also, this number is like a global parameter. If we set this here to e.g. 30, every other peer would still respond with the 20 closest peers it knows. The remaining ten that we receive are just other random close peers. @guillaumemichel devised a great technique to query for a wider range of peers which is more elaborate: https://www.notion.so/pl-strflt/N-closest-peers-83038476d00f4af1bfb40aeeefec39f5?pvs=4
There was a problem hiding this comment.
Yes it should be configurable. Though here the call to GetClosestNodes is getting the 20 closest nodes from our own routing table to seed the query.
There was a problem hiding this comment.
Indirectly used the DHT's bucketsize config value
* Move coord and kadt packages to internal * go mod tidy * go fmt * Move kadt out of internal and add RoutingTable interface
Rework the Coordinator's Query method into two separate versions:
QueryClosest attempts to find the closest nodes to a key and returns the ones it finds
QueryMessage iterates closer nodes using a supplied message
Also allows the NumResults query config option to be specified when starting a query. This specifies the minimum number of nodes to successfully contact before considering iteration complete. A query is considered to be exhausted when it has received responses from at least this number of nodes and there are no closer nodes remaining to be contacted.
Also implements the basic version of DHT.GetValue and a simple test that fetches a value from another node in the network using a query.